Skip to content

Commit

Permalink
inspections refactoring: level and naming (#56)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Hidanio
Hidanio authored Feb 6, 2025
1 parent 84096cd commit 1a6f92c
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 21 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

# Validate wrapper
- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation[email protected]
uses: gradle/actions/wrapper-validation@v3

# Set up Java environment for the next steps
- name: Setup Java
Expand Down Expand Up @@ -101,7 +101,7 @@ jobs:
# Collect Tests Result of failed tests
- name: Collect Tests Result
if: ${{ failure() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: tests-result
path: ${{ github.workspace }}/build/reports/tests
Expand Down Expand Up @@ -137,7 +137,7 @@ jobs:
# Collect Plugin Verifier Result
- name: Collect Plugin Verifier Result
if: ${{ always() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pluginVerifier-result
path: ${{ github.workspace }}/build/reports/pluginVerifier
36 changes: 18 additions & 18 deletions src/main/resources/META-INF/plugin.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,44 +41,44 @@
<notificationGroup id="Modulite" displayType="BALLOON"/>

<!-- YAML config inspections -->
<localInspection language="yaml" groupName="Modulite plugin" shortName="RequireSymbolFromModule"
<localInspection language="yaml" groupName="Modulite plugin" shortName="RequireSymbolFromModuliteInspection"
displayName="Require symbol from module"
enabledByDefault="true" level="WARNING"
enabledByDefault="true" level="ERROR"
implementationClass="com.vk.modulite.inspections.config.RequireSymbolFromModuliteInspection"/>

<localInspection language="yaml" groupName="Modulite plugin" shortName="UnknownSymbol"
<localInspection language="yaml" groupName="Modulite plugin" shortName="UnknownSymbolInspection"
displayName="Unknown symbol"
enabledByDefault="true" level="WARNING"
enabledByDefault="true" level="ERROR"
implementationClass="com.vk.modulite.inspections.config.UnknownSymbolInspection"/>

<localInspection language="yaml" groupName="Modulite plugin" shortName="UnknownModule"
<localInspection language="yaml" groupName="Modulite plugin" shortName="UnknownModuliteInspection"
displayName="Unknown modulite"
enabledByDefault="true" level="WARNING"
enabledByDefault="true" level="ERROR"
implementationClass="com.vk.modulite.inspections.config.UnknownModuliteInspection"/>

<localInspection language="yaml" groupName="Modulite plugin" shortName="UnknownComposerPackage"
<localInspection language="yaml" groupName="Modulite plugin" shortName="UnknownComposerPackageInspection"
displayName="Unknown composer package"
enabledByDefault="true" level="WARNING"
enabledByDefault="true" level="ERROR"
implementationClass="com.vk.modulite.inspections.config.UnknownComposerPackageInspection"/>

<localInspection language="yaml" groupName="Modulite plugin" shortName="EmptyValue"
<localInspection language="yaml" groupName="Modulite plugin" shortName="EmptyValueInListInspection"
displayName="Empty value"
enabledByDefault="true" level="WARNING"
enabledByDefault="true" level="WEAK WARNING"
implementationClass="com.vk.modulite.inspections.config.EmptyValueInListInspection"/>

<localInspection language="yaml" groupName="Modulite plugin" shortName="ModuleRedeclaration"
<localInspection language="yaml" groupName="Modulite plugin" shortName="ModuliteRedeclarationInspection"
displayName="Redeclaration of module"
enabledByDefault="true" level="ERROR"
implementationClass="com.vk.modulite.inspections.config.ModuliteRedeclarationInspection"/>

<localInspection language="yaml" groupName="Modulite plugin" shortName="UnnecessaryConfigFullyQualifiedName"
<localInspection language="yaml" groupName="Modulite plugin" shortName="ModuliteUnnecessaryFullyQualifiedNameInspection"
displayName="Unnecessary fully qualified name"
enabledByDefault="true" level="WARNING"
enabledByDefault="true" level="WEAK WARNING"
implementationClass="com.vk.modulite.inspections.config.UnnecessaryFullyQualifiedNameInspection"/>

<localInspection language="yaml" groupName="Modulite plugin" shortName="InvalidModuleNameInspection"
<localInspection language="yaml" groupName="Modulite plugin" shortName="InvalidModuliteNameInspection"
displayName="Incorrect module name"
enabledByDefault="true" level="WARNING"
enabledByDefault="true" level="ERROR"
implementationClass="com.vk.modulite.inspections.config.InvalidModuliteNameInspection"/>

<localInspection language="yaml" groupName="Modulite plugin" shortName="UnescapedBackSlashInNameInspection"
Expand Down Expand Up @@ -119,16 +119,16 @@

<localInspection language="PHP" groupName="Modulite plugin" shortName="WrongNamespaceInspection"
displayName="Wrong namespace"
enabledByDefault="true" level="WARNING"
enabledByDefault="true" level="ERROR"
implementationClass="com.vk.modulite.inspections.WrongNamespaceInspection"/>

<!-- Like intentions (only quick fixes) -->
<localInspection language="PHP" groupName="Modulite plugin" shortName="ChangeVisibilityIntention"
<localInspection language="PHP" groupName="Modulite plugin" shortName="ChangeVisibilityEmptyInspection"
displayName="Change visibility intention"
enabledByDefault="true" level="INFORMATION"
implementationClass="com.vk.modulite.inspections.intentions.ChangeVisibilityEmptyInspection"/>

<localInspection language="PHP" groupName="Modulite plugin" shortName="AllowInternalAccessIntention"
<localInspection language="PHP" groupName="Modulite plugin" shortName="AllowInternalAccessEmptyInspection"
displayName="Allow internal access intention for specific module"
enabledByDefault="true" level="INFORMATION"
implementationClass="com.vk.modulite.inspections.intentions.AllowInternalAccessEmptyInspection"/>
Expand Down

0 comments on commit 1a6f92c

Please sign in to comment.