WIP: added support for generics #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe inference Now this does not happen and the processing is divided into two parts.
Now provider does not provide any additional unresolved types in this case.
…y incorrect types
… the generic function
…ed some tests for class constructor
…ject language - Added intention to collapse generics instantiation comments - IDE version has been updated to 2022.1.1, as there is a bug in 2022.1 due to which KphpStormASTFactory does not work
…ad of a generic name
- improved a type tests error message
- added support for complex types
- added more comments
- added stubs for @kphp-inherit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generics support
At the moment, new generics are being developed in KPHP, which will become much more convenient and will also be applicable to classes, which will make developing in KPHP more convenient and safer.
However, when it comes to generic support in PhpStorm, we see a sad picture, the current support does not suit us and we want to have full control over the syntax and features of generics.
It is also worth considering that without support in the IDE, generics in KPHP will not be super convenient, any development with them will be accompanied by inconveniences, since the IDE simply will not understand them.
Therefore, we decided to try to make our own implementation and this PR for the moment adds initial support for generics for functions. Adding support for classes is planned for later, when issues with generics for functions are resolved.
Description of generics will be added a bit later.