BREAKING CHANGE: rm svg sprite #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevereCloud
force-pushed
the
SevereCloud/BREAKING-CHANGE/rm-svg-sprite
branch
from
86354fd to
3bc094e
Compare
👀 Docs deployedSee the docs for this PR at https://vkcom.github.io/icons/pull/1039/ |
size-limit report 📦
|
SevereCloud
force-pushed
the
SevereCloud/BREAKING-CHANGE/rm-svg-sprite
branch
2 times, most recently
from
4f29572 to
1deb49c
Compare
SevereCloud
force-pushed
the
SevereCloud/BREAKING-CHANGE/rm-svg-sprite
branch
from
1deb49c to
9d60798
Compare
SevereCloud
force-pushed
the
SevereCloud/BREAKING-CHANGE/rm-svg-sprite
branch
from
9d60798 to
f90a131
Compare
inomdzhon
reviewed
Dec 3, 2024
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
Избавляемся от svg спрайта
Был svg спрайт, теперь будет иконка. Это улучшает первую отрисовку для SSG/SSR, а также лучше по перфомансу
Избавляемся от cjs
Выпиливаем cjs во всех пакетах. Как минимум hast-util-from-html требует esm, а cjs иконки не умеют в тришейкинг