patch: pr8248 #8261
Merged
patch: pr8248 #8261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct with several FocusTraps (#8248) * fix(ModalPage, ModalCard): add prop `focusTrapDisabled` to fix conflict with several FocusTraps * doc(ModalPage,ModalCard): fix documentation * doc(ModalPage,ModalCard): fix docs * doc(ModalPage,ModalCard): fix docs * fix: rename `focusTrapDisabled` to `disableFocusTrap` # Conflicts: # packages/vkui/src/components/ModalCard/ModalCard.test.tsx # packages/vkui/src/components/ModalCard/ModalCardInternal.tsx # packages/vkui/src/components/ModalPage/ModalPage.test.tsx # packages/vkui/src/components/ModalPage/types.ts
andrey-medvedev-vk
approved these changes
Feb 12, 2025
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.1-stable #8261 +/- ##
===========================================
Coverage 95.53% 95.54%
===========================================
Files 397 397
Lines 11360 11361 +1
Branches 3753 3753
===========================================
+ Hits 10853 10855 +2
+ Misses 507 506 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disableFocusTrapto fix conflict with several FocusTraps #8248