Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PopoutWrapper): add prop strategy and deprecate prop fixed #8217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • Документация фичи
  • Release notes

Описание

Нужно добавить свойство strategy, которое управляет свойством position у PopoutWrapper

Изменения

  • Добавил свойство strategy
  • Задепрекейтил cвойство fixed, так как fixed позиционирование можно выставить через strategy
  • Добавил тесты

Release notes

Улучшения

  • PopoutWrapper: Добавлено свойство strategy для управления способом позиционирования компонентом

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner January 31, 2025 11:14
Copy link
Contributor

size-limit report 📦

Path Size
JS 394.61 KB (+0.05% 🔺)
JS (gzip) 119.61 KB (+0.05% 🔺)
JS (brotli) 98.28 KB (-0.09% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 347.47 KB (+0.03% 🔺)
CSS (gzip) 43 KB (+0.03% 🔺)
CSS (brotli) 34.3 KB (+0.04% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit f4688dd

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (6e09949) to head (f4688dd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8217   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         404      404           
  Lines       11531    11533    +2     
  Branches     3830     3831    +1     
=======================================
+ Hits        11014    11016    +2     
  Misses        517      517           
Flag Coverage Δ
unittests 95.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Strategy для PopoutWrapper
1 participant