fix(ModalPage): expect number for height #8209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Раньше `height` вставлялся в `style`, что позволяло передать без `px`. С переходом на CSS переменную эта возможность пропала, поэтому проверяем, что `height` это число и добавляем `px`.
github-actions
bot
added
the
patch
andrey-medvedev-vk
approved these changes
Jan 28, 2025
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit 344bcc6 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8209 +/- ##
==========================================
- Coverage 95.51% 95.50% -0.01%
==========================================
Files 403 403
Lines 11523 11525 +2
Branches 3827 3828 +1
==========================================
+ Hits 11006 11007 +1
- Misses 517 518 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BlackySoul
approved these changes
Jan 28, 2025
vkcom-publisher
pushed a commit
that referenced
this pull request
Jan 29, 2025
h2. Описание Раньше `height` вставлялся в `style`, что позволяло передать без `px`. С переходом на CSS переменную эта возможность пропала, поэтому проверяем, что `height` это число и добавляем `px`. - related to #6759 h2. Изменения Применил `megeStyle` в `style`, чтобы не применять object-spread когда не надо. h2. Release notes h2. Исправления - ModalPage: числовые значения в `height` не приводились к `${height}px`
| ✅ v7.1.2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Unit-тесты[ ] e2e-тесты[ ] Дизайн-ревью[ ] Документация фичиОписание
Раньше
heightвставлялся вstyle, что позволяло передать безpx. С переходом на CSS переменную эта возможность пропала, поэтому проверяем, чтоheightэто число и добавляемpx.Изменения
Применил
megeStyleвstyle, чтобы не применять object-spread когда не надо.Release notes
Исправления
heightне приводились к${height}px