patch: pr8200 #8206
Merged
patch: pr8200 #8206
+187
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Возвращаем адаптивность через AdaptivityProvider для: - `ModalOutlet` - определяем классы `hostDesktop` и `hostMobile`; - передаём `isDesktop` из `ModalPage` и `ModalCard`. - `ModalPage` - определяем классы `hostDesktop` и `hostMobile`; – также возвращаем ограничение по высоте, которое потерялось. - `ModalPageHeader` - определяем класс `hostDesktop`. - `ModalPageFooter` - определяем классы `hostDesktop` и `hostMobile`. - `ModalCard` - определяем классы `hostDesktop` и `hostMobile`; – по аналогии с `ModalPage` для **desktop** значение св-ва `box-sizing` заменено с `border-box` на `content-box`, чтобы не высчитывать `padding` из `max-width`. Для `ModalOverlay` не стал применять `useAdaptivityWithJSMediaQueries`, дабы не усложнять его. Привязку времени анимации к `@media` считаем допустимым.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
andrey-medvedev-vk
approved these changes
Jan 28, 2025
e2e tests
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.1-stable #8206 +/- ##
===========================================
Coverage 95.53% 95.53%
===========================================
Files 398 398
Lines 11346 11354 +8
Branches 3745 3753 +8
===========================================
+ Hits 10839 10847 +8
Misses 507 507
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit 8c6f945 |
SevereCloud
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Скриншоты
Фикс тут #8205