doc: Help styleguidist to detect proper name for Tabs page #8203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit 2b93483 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8203 +/- ##
=======================================
Coverage 95.50% 95.51%
=======================================
Files 403 403
Lines 11495 11515 +20
Branches 3807 3819 +12
=======================================
+ Hits 10978 10998 +20
Misses 517 517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
approved these changes
Jan 28, 2025
EldarMuhamethanov
approved these changes
Jan 28, 2025
andrey-medvedev-vk
added a commit
that referenced
this pull request
Jan 28, 2025
Исправляем отображение `Tabs` страницы в версиях доки v7.1.0 и v7.1.1, так как сейчас в этих версиях страница отображается как https://vkcom.github.io/VKUI/7.1.0/#/TabsModeContext и пропсы соответствуют `TabsModeContext`. Применил патч из #8203 конкретно к коду v7.1.0 и v7.1.1, для каждой версии пересобрал `styleguide` и результат добавил в ветку `gh-pages`.
andrey-medvedev-vk
added a commit
that referenced
this pull request
Jan 28, 2025
Merged
andrey-medvedev-vk
added a commit
that referenced
this pull request
Jan 28, 2025
| ✅ v7.1.2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В доке, начиная в версиях 7.1.0 7.1.1 пропала страница Tabs. Точнее она есть, но под другим именем
TabsModeContext: https://vkcom.github.io/VKUI/7.1.0/#/TabsModeContextStyleguideперестал адекватно понимать где в файлеTabsименно компонентTabs.Можно были либо перенести
TabsModeContextиз файлаTabsв отдельный, либо добавитьdisplayNameв соответсвии с документацией styleguideПроверил по коду, с остальными компонентами такой проблемы нету.
Явных причин по коду в изменениях между 7.0.1 и 7.1.0 для такого эффекта не заметил, возможно, что что-то в типах поменялось.