-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(RichCell): revert fix with after overflow #8199
fix(RichCell): revert fix with after overflow #8199
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit e7dfa8d |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8199 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 403 403
Lines 11503 11508 +5
Branches 3812 3816 +4
=======================================
+ Hits 10985 10990 +5
Misses 518 518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ PatchНе удалось автоматически применить исправление на ветке 7.1-stable.
Чтобы изменение попало в ветку 7.1-stable, выполните следующие действия:
git stash # опционально
git fetch origin 7.1-stable
git checkout -b patch/pr8199 origin/7.1-stable
git cherry-pick --no-commit 40a7218a674a5f7018dbaa69963bc7f76174d700
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
git push --set-upstream origin patch/pr8199
gh pr create --base 7.1-stable --title "patch: pr8199" --body "- patch #8199" |
К сожалению нет( я там ограничил maxWidth вручную |
(cherry picked from commit 40a7218)
Описание
В #7730 был поправлен баг с переполнение
аfter
в компонентеRichCell
. Но данное изменение оказалось слишком критическим и сломало много кейсов. Нужно откатить эти измененияИзменения
afterAlign !== 'start'
contentAlign
работает некорректно. Поправил багRelease notes
Исправления
after