Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Alert): Export AlertActionProps from Alert #8197

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

andrey-medvedev-vk
Copy link
Contributor

Описание

Экспортируем тип AlertActionProps. В этом есть смысл, так как у Alert есть проп renderAction в который можно предать функцию с аргументами типа AlertActionProps

Release notes

Улучшения

  • Alert: экспортирован тип AlertActionProps, тип аргументов функции, которую можно передать в renderAction

Copy link
Contributor

github-actions bot commented Jan 27, 2025

size-limit report 📦

Path Size
JS 393.13 KB (0%)
JS (gzip) 119.24 KB (0%)
JS (brotli) 98.13 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 344.54 KB (0%)
CSS (gzip) 42.71 KB (0%)
CSS (brotli) 34.02 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@andrey-medvedev-vk andrey-medvedev-vk marked this pull request as ready for review January 27, 2025 11:58
@andrey-medvedev-vk andrey-medvedev-vk requested a review from a team as a code owner January 27, 2025 11:58
Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 52d22fe

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (f0e139a) to head (52d22fe).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8197   +/-   ##
=======================================
  Coverage   95.49%   95.50%           
=======================================
  Files         403      403           
  Lines       11477    11495   +18     
  Branches     3795     3807   +12     
=======================================
+ Hits        10960    10978   +18     
  Misses        517      517           
Flag Coverage Δ
unittests 95.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-medvedev-vk andrey-medvedev-vk merged commit f2f7055 into master Jan 27, 2025
42 of 54 checks passed
@andrey-medvedev-vk andrey-medvedev-vk deleted the mendrew/8182/export-alert-action-props branch January 27, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Добавить экспорт типа для AlertActionProps
3 participants