fix(Alert): add FocusTrap props to Alert props #8136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests
|
👀 Docs deployed
Commit e3d962c |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8136 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 398 398
Lines 11379 11379
Branches 3757 3757
=======================================
Hits 10871 10871
Misses 508 508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
reviewed
Jan 9, 2025
Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
inomdzhon
approved these changes
Jan 9, 2025
BlackySoul
approved these changes
Jan 9, 2025
EldarMuhamethanov
deleted the
e.muhamethanov/8134/add-focus-trap-props-alert
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Jan 10, 2025
* fix(Alert): add FocusTrap props to Alert props * fix: pick only restoreFocus from UseFocusTrapProps Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]> --------- Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restoreFocus#8134Описание
Нужно добавить свойства
FocusTrapв свойства компонентаAlert, чтобыtsне ругался при прокидыванииRelease notes
Исправления
FocusTrapв свойстваAlert, так как они итак прокидывались вFocusTrap, но ругалсяTS