Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support react 19 types #8058

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Dec 10, 2024

Описание

Используем типизацию 19 react

Изменения

  • поправил работу с рефами
  • поправил работу с React.ReactElement
  • JSX заменил на React.JSX
  • временно запатчил @types/mdx
  • выпилил prop-types

Release notes

Улучшения

  • Исправлена типизация для React 19

Copy link
Contributor

size-limit report 📦

Path Size
JS 386.87 KB (+0.02% 🔺)
JS (gzip) 117.03 KB (-0.01% 🔽)
JS (brotli) 96.43 KB (-0.18% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 336.76 KB (0%)
CSS (gzip) 41.79 KB (0%)
CSS (brotli) 33.29 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.50%. Comparing base (334e5b2) to head (cdb8234).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/Epic/Epic.tsx 50.00% 2 Missing ⚠️
packages/vkui/src/lib/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8058      +/-   ##
==========================================
- Coverage   95.51%   95.50%   -0.01%     
==========================================
  Files         396      396              
  Lines       11235    11239       +4     
  Branches     3720     3721       +1     
==========================================
+ Hits        10731    10734       +3     
- Misses        504      505       +1     
Flag Coverage Δ
unittests 95.50% <92.68%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👀 Docs deployed

Commit cdb8234

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

не глядел на тему брейкинг чендж?

@SevereCloud
Copy link
Contributor Author

не глядел на тему брейкинг чендж?

Да

https://react.dev/blog/2024/04/25/react-19-upgrade-guide#typescript-changes

@SevereCloud SevereCloud added this to the v7.1.0 milestone Dec 11, 2024
@SevereCloud SevereCloud self-assigned this Dec 11, 2024
@SevereCloud SevereCloud merged commit d89135c into master Dec 11, 2024
26 of 28 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/feat/support-react-19-types branch December 11, 2024 10:07
@vkcom-publisher
Copy link
Contributor

v7.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants