Toggle or stop download thread-safely #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The download loop which downloads using libaria2 runs in a secondary thread. The downloader's toggle and stop functions were called from the main thread. The 'stop' case was probably harmless in practice, but the toggle case manipulates the aria objects which are concurrently used by the download thread in a dangerous way. Fix this by defining toggle and stop as signals which are sent to the downloader thread, and have the download loop manually check the thread's event queue.
DolceTriade
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The download loop which downloads using libaria2 runs in a secondary thread. The downloader's toggle and stop functions were called from the main thread. The 'stop' case was probably harmless in practice, but the toggle case manipulates the aria objects which are concurrently used by the download thread in a dangerous way.
Fix this by defining toggle and stop as signals which are sent to the downloader thread, and have the download loop manually check the thread's event queue.