Fix overlap disablement for mysql 8.0 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysql 8.0 can only deal with SRID 0, so when the server is 8.0*, this does hacky conversions into temp tables first and then runs the existing query using those temp tables.
|
Interesting. Golbat does not support mysql either so not sure who would be running this! |
There’s been at least 2 people, maybe 3 running it still :) |
|
I would approve a PR which disabled support for MySQL entirely in golbat. I will investigate how to detect and panic on start if MySQL detected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysql 8.0 can only deal with SRID 0, so when the server is 8.0*, this does hacky conversions into temp tables first and then runs the existing query using those temp tables.