Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get correct directory for writing .force_transcode file #3

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

OllysCoding
Copy link
Contributor

As discussed on Discord, this bug means that the .force_transcode is actually never properly written to:

The value returned by data.get('final_cache_path') is actually /tmp/unmanic/unmanic_file_conversion-dahwh-1705019796/It's Always Sunny in Philadelphia - S07E06 - The Storm of the Century Bluray-720p-gpdmc-1705020189.mkv.

So then on the next line, it's joining that value with .force_transcode, which gives the output /tmp/unmanic/unmanic_file_conversion-dahwh-1705019796/It's Always Sunny in Philadelphia - S07E06 - The Storm of the Century Bluray-720p-gpdmc-1705020189.mkv/.force_transcode

Now the actual file is at /tmp/unmanic/unmanic_file_conversion-dahwh-1705019796/.force_transcode, but since it's getting the final cache path of the file, not the folder the file is in, the if statement is getting false. That file it's looking for doesn't exist

This fix, suggested & tested by @yajrendrag, resolves it by getting the directory, instead of the file.

@OllysCoding OllysCoding force-pushed the olly/fix-force-transcode-file branch from 0f6b4c2 to b478501 Compare January 12, 2024 10:06
@Josh5 Josh5 merged commit 8a3e2a8 into Unmanic:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants