Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/example: add example on how to add opentelemetry headers/support #161

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

rarruda
Copy link
Collaborator

@rarruda rarruda commented Nov 6, 2023

this must be added before starting the unleash client. (in a rails initializer for example).

This is added as future reference/documentation for the solution to PR #150

Few will use opentelemetry, but it is nice to have to something to point to for those that use it.

Copy link
Contributor

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

Maybe add a note to the readme as well?

@rarruda rarruda force-pushed the example/opentelemetry_wrapper branch from 2329d63 to 5d2ee27 Compare November 9, 2023 09:40
this must be added before starting the unleash client.
(in a rails initializer for example).
@rarruda rarruda force-pushed the example/opentelemetry_wrapper branch from 5d2ee27 to 9a2ddb5 Compare November 9, 2023 09:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6810003264

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.186%

Totals Coverage Status
Change from base Build 6694841691: 0.0%
Covered Lines: 2521
Relevant Lines: 2594

💛 - Coveralls

@rarruda rarruda merged commit 85d430d into main Nov 29, 2023
40 checks passed
@rarruda rarruda deleted the example/opentelemetry_wrapper branch November 29, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants