Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge 1.12.1 and 1.12.2 into develop #3213

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

chore: merge 1.12.1 and 1.12.2 into develop #3213

wants to merge 6 commits into from
+17 −8

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Jan 22, 2025 •
edited by michalChrobot
Loading

Merging 1.12.1 and 1.12.2 patch releases back into develop

Changelog

NA

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
update
2e93d45 
incrementing to v1.12.1
@NoelStephensUnity
update
b66c6e9 
Setting changelog unreleased entries section to patch v1.12.1.
@NoelStephensUnity
update
123ff3d 
adding unreleased section to changelog.
@NoelStephensUnity NoelStephensUnity marked this pull request as draft January 24, 2025 16:33
@michalChrobot michalChrobot changed the title chore: merge 1.12.1 into develop chore: merge 1.12.1 and 1.12.2 into develop Jan 29, 2025
@NoelStephensUnity @michalChrobot
update
a7412d2 
Replace the two places where Debug.Assert is used in UnityTransport to be DEBUG wrapped checks that log warnings as opposed to throwing asserts in order to avoid being considered a failed test run even if all tests have passed.
@NoelStephensUnity @michalChrobot
style
5de9c10 
Cleaning up message a bit.
@NoelStephensUnity @michalChrobot
chore: validate 1.12.2 (#3215)
7bf15bb 
* update

Updating package and changelog.

* test

Changing what log message type we are expecting.

* test

Forgot to update message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispope chrispope Awaiting requested review from chrispope chrispope is a code owner

@miniwolf miniwolf Awaiting requested review from miniwolf miniwolf is a code owner

@fluong6 fluong6 Awaiting requested review from fluong6 fluong6 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NoelStephensUnity