Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: in-scene parenting WorldPositionStays transform synchronization without NetworkTransform [MTT-7856] #2796

Merged
merged 12 commits into from
Feb 2, 2024
Merged

fix: in-scene parenting WorldPositionStays transform synchronization without NetworkTransform [MTT-7856] #2796

merged 12 commits into from
Feb 2, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Dec 19, 2023 •
edited
Loading

This resolves an issue discovered with in-scene placed NetworkObjects where complex nested parent-child hierarchies would not synchronize properly when parenting changed using WorldPositionStays set to true. This also resolves an issue where the initial synchronization was not ordering NetworkObjects with parents before children with complex nested parent-child hierarchies. This update assures the parents will always proceed the children in the initial synchronization serialized NetworkObject order.

MTT-7856

Changelog

  • Fixed: Issue where in-scene placed NetworkObjects with complex nested children NetworkObjects (more than one child in depth) would not synchronize properly if WorldPositionStays was set to true.

Testing and Documentation

  • Includes a modification to the InSceneParentChildHandler integration test helper component.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
Test Fix
c4e719f 
InSceneParentChildHandler was not adding the server side objects to check.
@NoelStephensUnity
fix
abbaefd 
This fixes the issue with World Position Stays being set not working along this:
- The integration scene names not being added with complex nested children
- Parents and children were not being ordered as parent first then child

But now that this is fixed, the world position stays set to false no longer works (whack a mole).
@NoelStephensUnity
fix
6c2c47a 
Account for multiple children under any given parent for sorting.
Minor adjustment to how scale is synchronized with in-scene placed NetworkObjects.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner December 19, 2023 01:20
@NoelStephensUnity
test
4327e1f 
Updating this test
@NoelStephensUnity NoelStephensUnity changed the title fix: in-scene parenting WorldPositionStays transform synchronization without NetworkTransform fix: in-scene parenting WorldPositionStays transform synchronization without NetworkTransform [MTT-7856] Dec 19, 2023
@NoelStephensUnity
update
4c764d6 
updating the changelog.
@NoelStephensUnity
style
39ba3a6 
removing legacy debug script that was commented out.
@NoelStephensUnity
update
d6b0207 
Improving the parent sorting update
@NoelStephensUnity
Merge branch 'develop' into fix/in-scene-parenting-worldpositionstays…
b661d0f 
…-setting-no-nt
@NoelStephensUnity
update
34f37e5 
migrating changelog entry into unreleased region.
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) February 1, 2024 17:21
@NoelStephensUnity NoelStephensUnity merged commit d58ffb1 into develop Feb 2, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/in-scene-parenting-worldpositionstays-setting-no-nt branch February 2, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadauxCat ShadauxCat ShadauxCat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoelStephensUnity @ShadauxCat @netcode-ci-service