fix: Compatibility fixes for UTP 2.X #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-lemay-unity
requested review from
chrispope,
TylerUnity and
a team
as code owners
com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformPacketLossTests.cs
Outdated
Show resolved
Hide resolved
ShadauxCat
reviewed
Dec 4, 2023
| @@ -63,7 +63,7 @@ public unsafe void Handle(ref NetworkContext context) | |||
| using (WrappedMessage.WriteBuffer) | |||
| { | |||
| WrappedMessage.WriteBuffer.WriteBytesSafe(WrappedMessage.ReadBuffer.GetUnsafePtr(), WrappedMessage.ReadBuffer.Length); | |||
| networkManager.MessageManager.SendMessage(ref WrappedMessage, Delivery, nonServerIds); | |||
| networkManager.MessageManager.SendMessage(ref WrappedMessage, Delivery, nonServerIds.AsArray()); | |||
There was a problem hiding this comment.
I actually think NetworkMessageManager.SendMessage should be adjusted to support a NativeList overload rather than changing this to pass AsArray(). It could basically be a direct copy-paste of the NativeArray overload (which is only one line anyway).
…Technologies/com.unity.netcode.gameobjects into fix/collections-2.x-compatibility
NoelStephensUnity
approved these changes
Dec 6, 2023
ShadauxCat
approved these changes
Dec 7, 2023
TylerUnity
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous fixes to make NGO and its test project compatible with UTP 2.X:
NativeListtoNativeArray. That's deprecated in Collections 2.X and we now have to use the explicitAsArraymethod.UnityTransport, but that's not available anymore with UTP 2.X, where using the simulator in the tools package is now preferred. I'm not sure exactly how to write these tests to be compatible with both versions of UTP, so for now I opted to disable them if UTP 2.X is installed. Not ideal, but at least it allows compilation of the test project when using UTP 2.X.Changelog
N/A
Testing and Documentation