Optimize SqrtPriceMath.getAmount1Delta
#676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new function `absDiff` to `SqrtPriceMath` library which calculates the absolute difference between two numbers. Refactored the way price delta is computed between two prices in the `getAmount1Delta` function. The calculation is now more efficient.
hensha256
reviewed
May 21, 2024
| function absDiff(uint160 a, uint160 b) internal pure returns (uint256 res) { | ||
| assembly { | ||
| let diff := sub(a, b) | ||
| let mask := sar(255, diff) |
There was a problem hiding this comment.
could you add a similar comment to absTick? just something like
mask is all 1s if b > a or all 0s when a >= b
b-a = -(a-b) = invert (a-b-1)
hensha256
approved these changes
May 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out of #258.
Related Issue
Which issue does this pull request resolve?
Description of changes
Added a new function
absDifftoSqrtPriceMathlibrary which calculates the absolute difference between two numbers. Refactored the way price delta is computed between two prices in thegetAmount1Deltafunction. The calculation is now more efficient.Saves as much as 300 in runtime gas and 97 in bytecode size.