Code

Optimize SqrtPriceMath#258

Code

Closed

shuhuiluo wants to merge 41 commits intoUniswap:mainUniswap/v4-core:mainfrom Aperture-Finance:optimize-sqrtpricemathAperture-Finance/v4-core:optimize-sqrtpricemathCopy head branch name to clipboard

+210-77

Commits

Commits on Jun 16, 2023

• Add SqrtPriceMath forge tests and snapshot

  shuhuiluo

  committed
  677b62f

  Copy full SHA for 677b62f

• Optimize getNextSqrtPriceFromAmount0RoundingUp

  shuhuiluo

  committed
  5d4f82f

  Copy full SHA for 5d4f82f

• Optimize getNextSqrtPriceFromAmount1RoundingDown

  shuhuiluo

  committed
  072a4c2

  Copy full SHA for 072a4c2

• Optimize getNextSqrtPriceFromInput and getNextSqrtPriceFromOutput

  Show description for d8af24f
  shuhuiluo

  committed
  d8af24f

  Copy full SHA for d8af24f

• Optimize getAmount0Delta by introducing sort2 and removing branching

  shuhuiluo

  committed
  c66b805

  Copy full SHA for c66b805

• Optimize getAmount1Delta by introducing mulDiv96

  shuhuiluo

  committed
  5902613

  Copy full SHA for 5902613

• Optimize signed getAmount0Delta and getAmount1Delta using bit ops

  shuhuiluo

  committed
  ced1a76

  Copy full SHA for ced1a76

Commits on Apr 4, 2024

• Merge branch 'refs/heads/main' into optimize-sqrtpricemath

  Show description for 3c68aee
  shuhuiluo

  committed
  3c68aee

  Copy full SHA for 3c68aee

• Fix getNextSqrtPriceFromAmount0RoundingUp

  shuhuiluo

  committed
  f2c7ea3

  Copy full SHA for f2c7ea3

• Refactor FullMath.mulDiv96 and add tests

  shuhuiluo

  committed
  9713432

  Copy full SHA for 9713432

• Revert changes to SqrtPriceMathTest

  shuhuiluo

  committed
  cc0623d

  Copy full SHA for cc0623d

Commits on Apr 6, 2024

• Merge branch 'refs/heads/main' into optimize-sqrtpricemath

  Show description for 5a1d3da
  shuhuiluo

  committed
  5a1d3da

  Copy full SHA for 5a1d3da

• Update method name and snapshot values

  Show description for 5232cda
  shuhuiluo

  committed
  5232cda

  Copy full SHA for 5232cda

• Refactor function & variable names for clarity

  Show description for d829c2b
  shuhuiluo

  committed
  d829c2b

  Copy full SHA for d829c2b

• Optimize comparison to type(uint160).max in getNextSqrtPriceFromAmount1RoundingDown

  Show description for 4d7f5fe
  shuhuiluo

  committed
  4d7f5fe

  Copy full SHA for 4d7f5fe

Commits on Apr 7, 2024

• Update variable names in comments for mulDivQ96

  Show description for 5b183ba
  shuhuiluo

  committed
  5b183ba

  Copy full SHA for 5b183ba

Commits on Apr 8, 2024

• Implement 'absDiff' function to improve calculation in getAmount1Delta

  Show description for 45f0f2a
  shuhuiluo

  committed
  45f0f2a

  Copy full SHA for 45f0f2a

Commits on Apr 21, 2024

• Merge and update snapshots

  shuhuiluo

  committed
  fd9eeab

  Copy full SHA for fd9eeab

• Avoid casting and optimize further

  Show description for f82203a
  shuhuiluo

  committed
  f82203a

  Copy full SHA for f82203a

Commits on Apr 24, 2024

• Merge and update snapshots

  shuhuiluo

  committed
  3636004

  Copy full SHA for 3636004

Commits on Apr 26, 2024

• Refactor sign and mask calculation in SqrtPriceMath

  Show description for f3400fb
  shuhuiluo

  committed
  f3400fb

  Copy full SHA for f3400fb

Commits on May 11, 2024

• Merge and update snapshots

  shuhuiluo

  committed
  14f59d1

  Copy full SHA for 14f59d1

• Switch if else branches

  shuhuiluo

  committed
  9eb9020

  Copy full SHA for 9eb9020

Commits on May 18, 2024

• Merge and update snapshots

  shuhuiluo

  committed
  8a685ba

  Copy full SHA for 8a685ba

• Remove unused functions from UnsafeMath

  shuhuiluo

  committed
  435a4f3

  Copy full SHA for 435a4f3

Commits on May 19, 2024

• Add UnsafeMath.div and optimize SqrtPriceMath.getAmount0Delta

  Show description for bd96af9
  shuhuiluo

  committed
  bd96af9

  Copy full SHA for bd96af9

• Add assign function for direct uint conversion in SqrtPriceMath

  Show description for 04d35ab
  shuhuiluo

  committed
  04d35ab

  Copy full SHA for 04d35ab

• Add natspec on UnsafeMath.div

  shuhuiluo

  committed
  789b88d

  Copy full SHA for 789b88d

• Optimize signed variants of getAmount0Delta and getAmount1Delta

  Show description for a2c4b88
  shuhuiluo

  committed
  a2c4b88

  Copy full SHA for a2c4b88

Commits on May 22, 2024

• Merge and update snapshots

  shuhuiluo

  committed
  4e37569

  Copy full SHA for 4e37569

Commits on May 23, 2024

• Cast variables in assembly and use UnsafeMath.div

  shuhuiluo

  committed
  99104cb

  Copy full SHA for 99104cb

• Merge and update snapshots

  shuhuiluo

  committed
  df3c698

  Copy full SHA for df3c698

• Merge and update snapshots

  shuhuiluo

  committed
  d4aaf2f

  Copy full SHA for d4aaf2f

• Merge and update snapshots

  shuhuiluo

  committed
  a1a6bc7

  Copy full SHA for a1a6bc7

• Merge and update snapshots

  shuhuiluo

  committed
  e581828

  Copy full SHA for e581828

Commits on May 26, 2024

• Merge and update snapshots

  shuhuiluo

  committed
  d381756

  Copy full SHA for d381756

• Merge and update snapshots

  shuhuiluo

  committed
  d275b5b

  Copy full SHA for d275b5b

• Merge and update snapshots

  shuhuiluo

  committed
  efd2450

  Copy full SHA for efd2450

• Cast variables in assembly and use UnsafeMath.div

  shuhuiluo

  committed
  7047ddf

  Copy full SHA for 7047ddf

• Optimize signed variants of getAmount0Delta and getAmount1Delta

  shuhuiluo

  committed
  69ea63e

  Copy full SHA for 69ea63e

• Use FullMath.mulDivQ96 in SqrtPriceMath

  Show description for a8c1cc2
  shuhuiluo

  committed
  a8c1cc2

  Copy full SHA for a8c1cc2