Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use native eth for caching routing lambda token in and token out #983

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Jan 28, 2025

No description provided.

Copy link
Member Author

jsy1218 commented Jan 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jsy1218 jsy1218 marked this pull request as ready for review January 28, 2025 20:41
@graphite-app graphite-app bot requested review from a team, cgkol and xrsv January 28, 2025 20:42
@jsy1218 jsy1218 force-pushed the siyujiang/route-386-caching-bug-for-v4-eth branch from 5cf582f to ae36e38 Compare January 28, 2025 20:43
Copy link
Collaborator

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e need tests and this function applies right?

Copy link

graphite-app bot commented Jan 28, 2025

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (01/28/25)

4 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

Copy link
Member Author

jsy1218 commented Jan 28, 2025

unit test and function usage applied in the latest commit

Copy link
Member Author

jsy1218 commented Jan 28, 2025

im thinking to skip writing e2e test, to see if (1) prod stuck 0.0099 eth trade size cache can be refreshed (2) @xrsv local can no longer repro

@jsy1218 jsy1218 requested a review from cgkol January 28, 2025 22:42
@jsy1218 jsy1218 merged commit 572d0a9 into main Jan 28, 2025
8 checks passed
@jsy1218 jsy1218 deleted the siyujiang/route-386-caching-bug-for-v4-eth branch January 28, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants