Analytic Saturation Vapor Pressure #3726
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #3725.
In a Christmas Eve sprint, I implemented the analytic saturation vapor pressure from Ambaum 2020, per recommendations from #626. Lots of updated test values, and these may change further, but I wanted to get the changes out there quickly so we could evaluate their impacts, as well as get the changes into the full test matrix.
All departures are small in relative magnitude, but some callouts for potential scrutiny:
test_sensitive_sounding
test_lfc_ml
test_el
and its extensionstest_dewpoint_specific_humidity_xarray
(I reduced the precision instead of redefining the test data)test_equivalent_potential_temperature_masked
worked before. The calculations work on the individual masked array elements but for some reason it blows up on the full array.numpy.ma.exp
offered no help. If anyone has any insight here it had me pulling my hair out a bit.I'm not touching image tests until the other PR goes in and we tackle a review here, and maybe not even until LCL.
I'll include an implementation and tests for the saturation vapor pressure over ice in this PR as well.
Happy holidays! 🎅