chore(Dependencies): Updated NPM packages to fix security alerts #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two packages still have alerts, but they're low-severity and don't affect the executor service:
Web3 has an unfixed security alert (https://www.npmjs.com/advisories/877), but it’s regarding passwords/keys being stored in localStorage, so doesn’t affect the executor service (although it may affect the main UniTrade app).
The ethereum-waffle testing framework has an open PR for an update to one of their dependencies that’s causing the security alert (fix: bump node-fetch version TrueFiEng/Waffle#486); however, that’s a dev dependency and not used during runtime, so it shouldn’t affect the executor service either.