Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geode Predictor for 1.6.4+ #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

konkers
Copy link

@konkers konkers commented Apr 19, 2024

Requires the multiplayer ID so is only useful for dynamic seeding.

Requires the multiplayer ID so is only useful for dynamic seeding.
Copy link
Contributor

@PianoAddict PianoAddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method of returning GetGeodeContents1_6_4 from within GetGeodeContents1_6 renders the 1_6 method non functional as the multiplayerID is not an argument in the 1_6 method. recommend leaving the 1_6 method unchanged (reverting the line 116 change) and adding 1_6_4 as a separate method.

@konkers
Copy link
Author

konkers commented Apr 22, 2024

Since the arguments to Utility.CreateRandom default to 0.0, previous to 1.6.4 the seedC value was 0. The seedC parameter is now multiplayerId / 2. Since GetGeodeContents1_6 is now calling GetGeodeContents1_6_4 with a multiplayerId of 0, that should generate same seeds as not specifying the seedC parameter and letting it default to 0..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants