Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex pattern for extracting AsciiDoc links to not add period to end #95

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

theskillwithin
Copy link

@theskillwithin theskillwithin commented Dec 11, 2024

Description

Sometimes links extracted from markdown have random period at the end

fixes: #96

  message:"Cannot reach https://www.pharmacists.ca/cpha-ca/assets/File/minorailments/GERD_En_FINAL.pdf. Status: 403"  location:{path:"docs/resources/ailment_resources_links.md"  range:{start:{line:161  column:3}  end:{line:161  column:96}}}  severity:ERROR  source:{name:"linkspector"  url:"https://github.com/UmbrellaDocs/linkspector"}

Fixes # (issue number)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Information

Include any additional information about the pull request here.

@theskillwithin theskillwithin marked this pull request as draft December 11, 2024 03:23
@theskillwithin theskillwithin marked this pull request as ready for review December 11, 2024 03:31
@theskillwithin theskillwithin marked this pull request as draft December 11, 2024 03:47
@theskillwithin
Copy link
Author

actually just realized this is wrong code to change for markdown links

@theskillwithin
Copy link
Author

#96

@theskillwithin theskillwithin marked this pull request as ready for review December 11, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] When checking markdown file some links have trailing period
1 participant