[GH-62] Show scheduled test runs in Teams #63
Conversation
|
There was a problem hiding this comment.
Thanks @goulter, great work! I’ve left a few comments, but nothing major. I’m looking forward to hearing your thoughts on them.
Please let me know if we should remove the following files. Ideally, the main branch should contain only code that is actively deployed and used, which we can easily retrieve via GitHub if needed:
Thanks again!
| inputs: | ||
| target-idp-env: | ||
| description: > | ||
| NOTE: Running this workflows manually via this form will allow you to test the yaml of this workflow file and it will run the same tests as found in "No Slack - Run UW IdP Web Tests." | ||
| For "normal" on demand running of the idp tests, the "No Slack - Run UW IdP Web Tests" can be used. | ||
|
|
||
| target-idp-env. Acceptable values are `eval`, `prod`. The idp environment | ||
| you want to test against. | ||
| required: true | ||
| default: eval | ||
|
|
||
| target-idp-host: | ||
| description: > | ||
| target-idp-host. Optional. If provided, will add an /etc/hosts entry | ||
| targeting this host. | ||
| required: false |
There was a problem hiding this comment.
I noticed that the this workflow was significantly trimmed, and only the reason field was retained. Could you provide some background on why the other functionality was removed? Just trying to understand the context behind this change.
Before:
This Branch:
There was a problem hiding this comment.
Ah, right. The main branch in this case is a little misleading. I changed the scheduled task when I merged the an older PR I created for the run on demand workflow. I put the workflow_dispatch it in there originally just to run the scheduled one on demand. The finished version (the one in this PR) strips out most of the form fields I introduced. I can clarify more if you'd like.
There was a problem hiding this comment.
Awesome, thanks for the context! That clears things up. I noticed this was added about three weeks ago and has now been removed—makes sense to me. We're all set then. Thanks so much! 🙂
| description: > | ||
| pytest-args. Any args you want to send to pytest. You do not ever need to | ||
| supply `log_cli` arguments. | ||
| required: false |
|
|
|
|
|
This change brings the old slack notification of the scheduled tests over to teams. Documentation also updated.
Closes GH-62
When this runs on its schedule, the reason will read "Scheduled run"
