[GH-41] Update eval and prod tests to accomodate for new "remember me" style cookie, and a few other ancillary/supporting changes. #42

goulter · 2024-03-01T21:03:41Z

Closes GH-41

A number of adjustments were made to the tests, especially when run against eval, to accomodate the new "remember me" style cookie that is now generated by duo.
Code was also changed to:
run the reauth tests (no longer skipped)
look for and use the new "is this your device screen"

…s part of the iframe page)

…is their device

…e comments, remove debugs

…member, dont look for the rememberme cookie (rely on user experience instead)

github-actions · 2024-03-01T21:25:25Z

Test result: success
Storyboards
Commit 57cd7e9

tests/conftest.py

tests/test_2fa_duo.py

goulter · 2024-03-04T16:14:15Z

@miker985 thanks for your attention on those sleeps. One or two of them might have been in there for debugging. If I didn't use a wait its b/c the wait didn't work as it should, for whatever reason. I'll revisit the sleeps.

tests/conftest.py

github-actions · 2024-03-04T18:31:08Z

Test result: success
Storyboards
Commit 419d73c

goulter added 10 commits February 20, 2024 14:39

skip the forced reatuh 2fa for now, not supported, for now.

836b196

Account for 'is this your device' screen, a slew of debugs, some sleeps

1090b3c

Account for cases where user wont see the 'is this your device' screen

e9961e9

For the crn cases, we dont show which identity is being used (that wa…

052d70b

…s part of the iframe page)

More cases where the 'is this your device' screen shows

2e8150d

A few more places where the user doesnt need to be asked again, is th…

5d464ab

…is their device

Convert some of the inline code to functions for readability, add som…

021a0cd

…e comments, remove debugs

accomodate for flows where the 'is this your device' screen do not show

03b6359

cases where we do or dont want to remember this is the users device

d182367

cases where we dont want to remember the device, add eval case for re…

d6da8f9

…member, dont look for the rememberme cookie (rely on user experience instead)

goulter requested review from jprosser, soufianerafik, miker985, jdiverp, mar235av and chmc3 March 2, 2024 00:18

goulter marked this pull request as ready for review March 2, 2024 00:18