Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-169] Fix create-release.yml Workflow Issues and Update Poetry Tox Command Syntax #172

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

soufianerafik
Copy link
Contributor

@soufianerafik soufianerafik commented Jan 17, 2025

Change Description: This PR fixes issues with the create-release.yml workflow by making the following updates:

  1. Installations and Setup:

    • Setting up Python 3.10 using actions/setup-python@v4.
    • Installing Poetry manually with pip
  2. Command Fixes:

  3. Other Minor Adjustments:

    • Added names to a few steps for better clarity.
    • Added workflow_dispatch to allow manual triggering of the workflow.

Testing:
To test this workflow before merging, I temporarily added the branch name GH-169 so that the workflow was triggered, and everything is now green.

Screenshot 2025-01-16 at 5 09 19 PM Screenshot 2025-01-16 at 5 09 02 PM

Closes Gihutb(s): GH-169

UW-Directory Pull Request checklist

  • I have run poetry run tox
  • I have selected a semver-guidance: label for this pull request (under labels,
    to the right of the screen)

@soufianerafik soufianerafik added the semver-guidance:no-bump Use this when you don't want the version to change. label Jan 17, 2025
@soufianerafik soufianerafik self-assigned this Jan 17, 2025
@soufianerafik soufianerafik changed the title [GH-169] - fix(ci): Fix create-release.yml workflow [GH-169] Fix create-release.yml Workflow Issues and Update Poetry Tox Command Syntax Jan 17, 2025
Copy link
Contributor

Download and run the latest build with:

./scripts/run-development-server.sh -i gcr.io/uwit-mci-iam/husky-directory.app:pull-request-172

@soufianerafik soufianerafik linked an issue Jan 17, 2025 that may be closed by this pull request
@soufianerafik soufianerafik linked an issue Jan 17, 2025 that may be closed by this pull request
@soufianerafik soufianerafik marked this pull request as ready for review January 17, 2025 02:17
@jdiverp
Copy link
Contributor

jdiverp commented Jan 17, 2025

I'm not going to be able to provide quality feedback here. Defer to @jprosser

Copy link
Contributor

@goulter goulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a couple questions, but good to go.

.github/workflows/create-release.yml Show resolved Hide resolved
.github/workflows/create-release.yml Show resolved Hide resolved
@soufianerafik soufianerafik merged commit 0466529 into main Jan 17, 2025
2 checks passed
@soufianerafik soufianerafik deleted the GH-169 branch January 17, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-guidance:no-bump Use this when you don't want the version to change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update create-release.yml Workflow
3 participants