-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Db migration #49
Db migration #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -79,8 +80,8 @@ public RelyingParty getRelyingPartyById(String id) throws RelyingPartyException | |||
return rps.get(0); | |||
} | |||
else { | |||
String errorMsg = String.format("error getting rp: %s, rps size = %s", id, rps.size()); | |||
log.debug(errorMsg); | |||
String errorMsg = String.format("error getting rp: %s, rps size = %s", id, (rps == null) ? 0 : rps.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional nit: Extract into a local variable.
It can help to minimize computations done in format statements, so that readers can focus on understanding the format string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to ignore this for now. This error message is almost never used; I made the smallest update possible to get it to not NullPointerException.
Updates to support migration to a GCP database.