Format the codebase using google-java-format #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed and looks OK. I didn't do a full validation as it's clear that even though there are a lot of changes, they are all driven by running a standard formatter in which we can have confidence. |
When run, this will automatically format all files to follow the Google style guide.
Doing this now will prevent spurious diffs in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds the google-java-formatter (via spotless) to our pom.xml, and the second simply runs it. Though this PR is large now, it will help prevent misconfigured IDEs from mis-formatting the code in the future.
This is a large PR because it was generated by an automated tool.
If you wish to verify this PR, you can copy the pom.xml settings, then run the following maven command.
You should end up with the exact same repo state as this PR.