Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Db migration #71

Merged
merged 7 commits into from
Apr 8, 2024
Merged

Db migration #71

merged 7 commits into from
Apr 8, 2024

Conversation

mar235av
Copy link
Contributor

@mar235av mar235av commented Apr 5, 2024

Changes to support the migration to a GCP database.

  1. Modified the application context to use a new connection pool and include the SSL connection parameters. All connection configuration is now in the context file.
  2. Modified the one class that uses the database connection object. Removed configuration parameters and changed the object type to a generic DataSource type.
  3. Updated pom.xml with some minor library version updates per recommendation from Dependabot.

@mar235av mar235av requested a review from stea-uw April 5, 2024 01:23
stea-uw
stea-uw approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@stea-uw stea-uw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mar235av mar235av merged commit f204022 into main Apr 8, 2024
1 check passed
@mar235av mar235av deleted the dbPool branch April 8, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stea-uw stea-uw stea-uw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mar235av @stea-uw