Fix tool_choice being dropped in inspect_model_request #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexb-palisaderesearch
force-pushed
the
tool-choice
branch
from
2ee66f9 to
8af7553
Compare
|
Thanks for this! The types are actually not identical so we can't just assign them straight up. Here's a variation that does the requisite mapping: #1450. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
What is the current behavior?
tool_choicepassed fromOpenAI().chat.completions.create(tool_choice=...)gets replaced withNone.What is the new behavior?
tool_choicegets preserved and passed down tomodel.generate().Does this PR introduce a breaking change?
No.
Other information: