Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERV-1189] Add validator interface #31

Merged
merged 11 commits into from
Jan 15, 2025
Merged

[SERV-1189] Add validator interface #31

merged 11 commits into from
Jan 15, 2025

Conversation

ksclarke
Copy link
Member

@ksclarke ksclarke commented Nov 18, 2024

  • Further parameterize parts of the Docker image build
  • Use exec in ENTRYPOINT for better process control
  • Use sh in ENTRYPOINT to be able to use ENV properties
  • Add HEALTHCHECK to Docker image
  • Add first passes at Validator and CsvLocation
  • Clean up obsolete ENVs that are now hard-coded in the Dockerfile
  • Create unique job names for nightly and release to make ACT use easier
  • Changed the way GA vars are handled to make ACT use easier
  • Use tags to isolate functional tests (requiring Docker) from unit tests (standalone)
  • Update project's README with the latest processes/documentation
  • Remove Docker compose file, leaving manual steps, Makefile, or ACT as build options
  • Switched to using fmt.Sprintf() instead of string concatenation in some of the tests

@ksclarke ksclarke self-assigned this Nov 18, 2024
@ksclarke ksclarke marked this pull request as ready for review January 7, 2025 22:52
@ksclarke ksclarke requested a review from a team as a code owner January 7, 2025 22:52
README.md Outdated Show resolved Hide resolved
csv_location_test.go Outdated Show resolved Hide resolved
@ksclarke ksclarke merged commit 73e5622 into main Jan 15, 2025
2 checks passed
@ksclarke ksclarke deleted the SERV-1189 branch January 15, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants