feat: display static images #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcefilter
changed the title
sourcefilter
force-pushed
the
stage/NOP-21/external-images
branch
4 times, most recently
from
36044cb to
a7777b7
Compare
Our current version of universal viewer fails to render images that are included as a simple file link, instead of a iiif service. This is fixed in UV 4.0.25, but other of our options break. This PR renders these images as a simple <img> tag, instead of using UV.
sourcefilter
force-pushed
the
stage/NOP-21/external-images
branch
14 times, most recently
from
e8adab9 to
4cb2f5e
Compare
sourcefilter
force-pushed
the
stage/NOP-21/external-images
branch
from
4cb2f5e to
ed91da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current version of universal viewer fails to render images that are included as a simple file link, instead of a iiif (ie, cantaloupe) service. This is fixed in UV 4.0.25, but other of our options break. This PR renders these images as a simple![]()
tag, instead of using UV.
Also fixes an issue where collection documents are misidentified as Images. We were looking for
iiif_manifest.type: "Collection"when the manifest hadiiif_manifest.@type: "sc:Collection". This wasn't an issue previously because images and collections were both passed on to UV.