Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback fix daria #56

Merged
merged 4 commits into from
Feb 1, 2025
Merged

Feedback fix daria #56

merged 4 commits into from
Feb 1, 2025

Conversation

dariakhv
Copy link
Collaborator

@dariakhv dariakhv commented Feb 1, 2025

addressed peer review feedback:

  1. DongchunChen: predict_sales could include additional metrics, the function now only prints MSE --> predict_sales.py
  2. Jenson-Chen: test_predict_sales.py imports test data while the other two tests uses pytest_fixture. --> test_predict_sales.py + removed test_data.csv
  3. Lukman-Lateef include a general interpretation of MSE and the prediction result in the vignette --> example.ipynb

@dariakhv dariakhv self-assigned this Feb 1, 2025
@dariakhv dariakhv added the enhancement New feature or request label Feb 1, 2025
@dariakhv dariakhv added this to the Milestone 4 milestone Feb 1, 2025
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (7d8168a) to head (f8b4fab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   99.09%   99.10%   +0.01%     
==========================================
  Files           4        4              
  Lines         110      112       +2     
==========================================
+ Hits          109      111       +2     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jim-franklin jim-franklin merged commit cb4b2f6 into main Feb 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants