Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/quicksort tests #29

Merged
merged 19 commits into from
Jan 18, 2025
Merged

Feature/quicksort tests #29

merged 19 commits into from
Jan 18, 2025
+205 −71

Conversation

shashankhs11
Copy link
Collaborator

  • Ensure the function handles incorrect input and errors by throwing exceptions with useful error messages.
  • Wrote unit tests for the quicksort function.
  • Ensured all unit tests pass using the pytest package.
  • Ensured 100% code coverage for the written function.
  • Added pytest dependency.

Nonso-M and others added 17 commits January 14, 2025 18:18
@Nonso-M
wrote functions and tested them using pytest
d310e8c
@shashankhs11
added basic tests
1bd6051
@shashankhs11
tests for list and types in the list
547c580
@shashankhs11
added more complex tests
66f425c
@shashankhs11
Merge branch 'feat-bubblesort' into 'feature/quicksort-func' - to get…
4977107 
… few dependency files
@shashankhs11
implementation for quicksort
9e6b580
@shashankhs11
Merge branch 'feat-bubblesort' into 'feature/quicksort-tests' to get …
4cbd97f 
…common files
@shashankhs11
added more fixtures for quicksort testing
410ad80
@shashankhs11
updated tests to use fixtures
7bac198
@shashankhs11
Merge branch 'feature/quicksort-func' of github.com:UBC-MDS/pysorting…
8a79824 
… into feature/quicksort-tests - updating func quicksort
@shashankhs11
updated import statement
e64c5ca
@shashankhs11
Merge branch 'main' of github.com:UBC-MDS/pysorting into feature/quic…
5d77a6c 
…ksort-tests
@shashankhs11
made changes in pytest fixtures
0d6cd25
@shashankhs11
updated import statement in test file
426f76b
@shashankhs11
added pytest-cov
db3706c
@shashankhs11
made slight changes to quicksort implementation to get 100% cov
489463c
@shashankhs11
updated init.py to remove duplicated imports
f8f2746
@shashankhs11 shashankhs11 added this to the Milestone 2 milestone Jan 18, 2025
@shashankhs11 shashankhs11 linked an issue Jan 18, 2025 that may be closed by this pull request
Testing and Development Checklist for QuickSort #22
Closed
@shashankhs11 shashankhs11 requested a review from MarekB19 January 18, 2025 23:19
MarekB19
MarekB19 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@MarekB19 MarekB19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you Shashank!

src/pysorting/bubblesort.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the bubble sort file belongs to Nonso's branch.. it should maybe not be committed as part of this pr

@MarekB19 MarekB19 merged commit d24c56f into main Jan 18, 2025
2 of 4 checks passed
@MarekB19 MarekB19 deleted the feature/quicksort-tests branch January 18, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekB19 MarekB19

Assignees
No one assigned
Labels
None yet
Projects
524 - pysorting
Status: Done
Milestone
Milestone 2
Development

Successfully merging this pull request may close these issues.

Testing and Development Checklist for QuickSort
3 participants
@shashankhs11 @MarekB19 @Nonso-M