Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer review dhruv fix #76

Merged
merged 5 commits into from
Feb 1, 2025
Merged

Peer review dhruv fix #76

merged 5 commits into from
Feb 1, 2025

Conversation

vrudhgarg
Copy link
Collaborator

Did a chain of fixes from peer review. Please change/update them if needed

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.61%. Comparing base (1110743) to head (ff278a1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   98.52%   98.61%   +0.08%     
==========================================
  Files           5        5              
  Lines          68       72       +4     
==========================================
+ Hits           67       71       +4     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrudhgarg vrudhgarg linked an issue Feb 1, 2025 that may be closed by this pull request
5 tasks
Copy link
Collaborator

@ThamerD ThamerD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment