Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cheng's fixes #57

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Cheng's fixes #57

merged 2 commits into from
Feb 1, 2025

Conversation

agendazhang
Copy link
Collaborator

No description provided.

@agendazhang agendazhang changed the title fix: Feedback addressed to add "Raises" section in the function docstring Cheng's fixes Feb 1, 2025
@agendazhang agendazhang added the ready for review For code and issues that are ready to be reviewed label Feb 1, 2025
@agendazhang agendazhang added this to the milestone 4 milestone Feb 1, 2025
merari95
merari95 approved these changes Feb 1, 2025
View reviewed changes
Copy link
Collaborator

@merari95 merari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your function is more concise now. You also addressed the ValueError and TypeError. Great work!

@merari95 merari95 merged commit 4e86a55 into main Feb 1, 2025
4 checks passed
@Psingh238 Psingh238 deleted the fix-feedback-cheng branch February 3, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merari95 merari95 merari95 approved these changes

Assignees
No one assigned
Labels
ready for review For code and issues that are ready to be reviewed
Projects
Collaborative Software Development
Status: Done
Milestone
milestone4
Development

Successfully merging this pull request may close these issues.
2 participants
@agendazhang @merari95