-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrangling chapter review #235
Conversation
…s, piping in data frame as per reviewers comments
…s, piping in data frame as per reviewers comments
@ttimbers Changes look good! Only thing is the one below "Montreal" is spelled "Montreak"
|
Good catch! |
…ta from the canlang package as I don't think we want to add that complexity...
I also removed loading data from the canlang package and instead get them to read the data from files. I don't think we really explain data packages and they are kind of weird, so best to leave out I think? |
Yes, I agree with that! Makes sense! |
@leem44 - I am also removing the demonstration of |
@leem44 - in the wrangling chapter, are you OK to move the pipe to before If I do that, then I will use |
Maybe not actually - I am now fence sitting on this change, as it causes cascading changes... Decided not to do this. |
Simplified the example to just plot the proportion of people speaking English as the primary language at home. |
Done all sections except for |
…ll need to add back in how to deal with NAs for summarize + across and purr map
OK, I think we are ready to merge. I added a bunch of images into the wrangling chapter, and re-organized the section where we do aggregation. I am pretty excited about it. @leem44 - I made quite a few changes to the wrangling chapter to (hopefully) simplify it. I hope that is OK. If there is anything I removed that you really want to keep in, please let me know and we can talk and find a way to keep it. |
@leem44 gave me the go-ahead to merge, so merging! |
@trevorcampbell @ttimbers Please have a look at this PR and let me know if I should make any changes!
This PR addresses: #103, #160
map
from this chapter -- I figure its easier to get any feedback on this, make changes and then create a branch off of this to removemap