Skip to content

Commit

Permalink
asd
Browse files Browse the repository at this point in the history
  • Loading branch information
Tyrrrz committed Nov 23, 2023
1 parent c6d2d1c commit ed734d0
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 24 deletions.
2 changes: 1 addition & 1 deletion CliWrap.Magic.Tests/ExecutionSpecs.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class ExecutionSpecs
public async Task I_can_execute_a_command_with_magic_and_get_the_stdout_and_stderr()
{
// Arrange
var cmd = Run(
var cmd = Command(
Dummy.Program.FilePath,
new[] { "echo", "Hello stdout and stderr", "--target", "all" }
);
Expand Down
16 changes: 16 additions & 0 deletions CliWrap.Magic/MagicalCommandResult.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
using CliWrap.Buffered;

namespace CliWrap.Magic;

public class MagicalCommandResult : BufferedCommandResult

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / format

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / format

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / format

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / test (windows-latest)

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / test (windows-latest)

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / test (windows-latest)

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / test (windows-latest)

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / format

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / format

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / format

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / test (windows-latest)

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / test (windows-latest)

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / test (windows-latest)

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'

Check failure on line 5 in CliWrap.Magic/MagicalCommandResult.cs

View workflow job for this annotation

GitHub Actions / main / test (windows-latest)

There is no argument given that corresponds to the required parameter 'exitCode' of 'BufferedCommandResult.BufferedCommandResult(int, DateTimeOffset, DateTimeOffset, string, string)'
{
/// <summary>
/// Converts the result to an integer value that corresponds to the <see cref="CommandResult.ExitCode" /> property.
/// </summary>
public static implicit operator int(MagicalCommandResult result) => result.ExitCode;

/// <summary>
/// Converts the result to a boolean value that corresponds to the <see cref="CommandResult.IsSuccess" /> property.
/// </summary>
public static implicit operator bool(MagicalCommandResult result) => result.IsSuccess;
}
16 changes: 8 additions & 8 deletions CliWrap.Magic/Tools.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public static partial class Tools
/// <summary>
/// Creates a new command that targets the specified command-line executable, batch file, or script.
/// </summary>
public static Command Run(string targetFilePath) =>
public static Command Command(string targetFilePath) =>
Cli.Wrap(targetFilePath)
.WithStandardInputPipe(DefaultStandardInputPipe)
.WithStandardOutputPipe(DefaultStandardOutputPipe)
Expand All @@ -23,18 +23,18 @@ public static Command Run(string targetFilePath) =>
/// Creates a new command that targets the specified command-line executable, batch file, or script,
/// with the provided command-line arguments.
/// </summary>
public static Command Run(string targetFilePath, string arguments) =>
Run(targetFilePath).WithArguments(arguments);
public static Command Command(string targetFilePath, string arguments) =>
Command(targetFilePath).WithArguments(arguments);

/// <summary>
/// Creates a new command that targets the specified command-line executable, batch file, or script,
/// with the provided command-line arguments.
/// </summary>
public static Command Run(
public static Command Command(
string targetFilePath,
IEnumerable<string> arguments,
bool escape = true
) => Run(targetFilePath).WithArguments(arguments, escape);
) => Command(targetFilePath).WithArguments(arguments, escape);

/// <summary>
/// Gets the current working directory.
Expand Down Expand Up @@ -79,19 +79,19 @@ public static IDisposable Environment(string name, string? value)
public partial class Tools
{
/// <summary>
/// Default standard input pipe used for commands created by <see cref="Run(string)" />.
/// Default standard input pipe used for commands created by <see cref="Command" />.
/// </summary>
public static PipeSource DefaultStandardInputPipe { get; set; } =
PipeSource.FromStream(Console.OpenStandardInput());

/// <summary>
/// Default standard output pipe used for commands created by <see cref="Run(string)" />.
/// Default standard output pipe used for commands created by <see cref="Command" />.
/// </summary>
public static PipeTarget DefaultStandardOutputPipe { get; set; } =
PipeTarget.ToStream(Console.OpenStandardOutput());

/// <summary>
/// Default standard error pipe used for commands created by <see cref="Run(string)" />.
/// Default standard error pipe used for commands created by <see cref="Command" />.
/// </summary>
public static PipeTarget DefaultStandardErrorPipe { get; set; } =
PipeTarget.ToStream(Console.OpenStandardError());
Expand Down
16 changes: 1 addition & 15 deletions CliWrap/CommandResult.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace CliWrap;
/// <summary>
/// Result of a command execution.
/// </summary>
public partial class CommandResult
public class CommandResult
{
/// <summary>
/// Exit code set by the underlying process.
Expand Down Expand Up @@ -42,17 +42,3 @@ public CommandResult(int exitCode, DateTimeOffset startTime, DateTimeOffset exit
ExitTime = exitTime;
}
}

// This stuff is only needed by CliWrap.Magic, but we can't implement operators for this type in another assembly
public partial class CommandResult
{
/// <summary>
/// Converts the result to an integer value that corresponds to the <see cref="ExitCode" /> property.
/// </summary>
public static implicit operator int(CommandResult result) => result.ExitCode;

/// <summary>
/// Converts the result to a boolean value that corresponds to the <see cref="IsSuccess" /> property.
/// </summary>
public static implicit operator bool(CommandResult result) => result.IsSuccess;
}

0 comments on commit ed734d0

Please sign in to comment.