feat: Allow explicit definition of what API resources should be monitored #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next step is here. |
TwiN
requested changes
Dec 19, 2024
There was a problem hiding this comment.
The TRACKABLE_RESOURCES environment variable name isn't really clear. What resources are you talking about here? API resources? actual resource names? Perhaps an environment variable name such as API_RESOURCES_TO_WATCH would make more sense, as it conveys what the environment variable is trying to do.
Also, please add some documentation on how to use this feature.
TwiN
changed the title
|
@TwiN It's ready for review :) |
TwiN
approved these changes
Jan 3, 2025
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #100
I've decided to go with simple implementation at first and take trackable resources from the environment variable.
Checklist
README.md, if applicable.