Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wikipedia extension (fixed) #1941

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

samuellouf
Copy link
Contributor

Hello!
I'm re-pulling my "Wikipedia" extension.
I fixed the issues adressed it my previous pull request (#1075) :
See here.
It still uses MediaWiki public API.
Enjoy !
Post-scriptum :
Here is the logo :
Logo

And here is the banner :

Wikipedia Banner

samuellouf and others added 6 commits October 2, 2023 18:40
Added my Wikipedia extension to the list
Replaced 'fetch()' by 'Scratch.fetch()'
Detail :
 - Created my own logo (Puzzle piece with a W)
 - Added License
 - Returns empty strings instead of 'Error : [...]'
 - Added a fallback empty string for "getLanguage"
 - Removed "isString" cause I didn't need it
 - Switched the function names to camel case
 - Removed "wikipedia" from the function names
 - Added "addLanguage"
 - Edited JSON array filter to return JSON objects
 - Made a banner
@github-actions github-actions bot added the pr: new extension Pull requests that add a new extension label Feb 19, 2025
@NexusKitten
Copy link
Contributor

Just for future reference, I'm pretty sure you're allowed to reopen a commit marked as stale if you've updated it. Typically, there's nothing wrong with a stale PR, they're just closed to cut down on the amount of inactive pull requests.

- Changed User Adress
- Removed text from banner
@samuellouf
Copy link
Contributor Author

Oh! Ok. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants