fix: stop runit services gracefully #44 #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44
Please read that issue for details of the problem and replication instructions.
Inspired by peterbourgon/runsvinit#3, this aims to solve the issue of stopping services gracefully when the docker container is stopped.
Testing instructions
docker run --rm -it --name tb-test-mariadb-old docker.io/tugboatqa/mariadb
docker stop tb-test-mariadb-old
task -- mariadb
docker run --rm -it --name tb-test-mariadb-new tugboatqa/mariadb
docker stop tb-test-mariadb-new