refactor!: Fail gracefully when looking up exports #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ferdinand
force-pushed
the
better_snippet_export_pr
branch
from
818c4cf to
04309be
Compare
BREAKING CHANGE: Remove the implementation of `DeprecatedSnippet` for `list::length::Length`, implement `BasicSnippet` directly.
jan-ferdinand
force-pushed
the
better_snippet_export_pr
branch
from
04309be to
6bb67c6
Compare
- use naming scheme consistent with other snippets - add missing exports - list exports lexicographically
In particular, remove the field `element_type` from the structs - `list::new::New`, - `list::length::Length`, and - `list::set_length::SetLength`. The element type does not influence the snippets' behavior.
jan-ferdinand
force-pushed
the
better_snippet_export_pr
branch
from
6bb67c6 to
ca6da23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.