rewrite & sign off on snippet verify_mmr_successor
#152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Remove snippet `u64::index_of_last_nonzero_bit`, which more or less computes the same thing as `trailing_zeros`, but is less efficient, less general since it fails on input “0”, and uses an uncommon name.
BREAKING CHANGE: Remove the implementation of `DeprecatedSnippet` for `u64::shift_left::ShiftLeft`, implement `BasicSnippet` directly.
Rewrite the snippet to use the new algorithm introduced in `twenty-first` v0.44.1. Also: - document & sign-off on the snippet - add additional negative test cases
Sword-Smith
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-write snippet
verify_mmr_successorto mimic the new algorithm introduced intwenty-firstv0.44.1. Add additional snippetsu64::trailing_zerosandhashing::merkle_step_mem_u64, which are needed for the new verification algorithm.