Thv/option types #56
Merged
Thv/option types #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is somewhat hacky, and I'm not sure I want to keep it. With this patch, the AST is rewritten in the type checker such that a literal `None` is rewritten to a enum variant declaration `Option::None`. I think we need to handle this case in the type checker, since that's the only place where the relevant type information is present, but I'm not sure this handling is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
Option<T>types.This one got more messy than I had hoped for, as the intermediate AST is rewritten from
Expr::VartoExpr::EnumDeclarationin the type checker. I struggled a bit finding the right way of handling multiple instances ofNone(when multiple Option) are in scope, and this is all I could come up with.I added some
assertstatements to bind down the return value that is responsible for theExpr::Var->Expr::EnumDeclarationrewrite. So at least we check at run-time when I couldn't handle at compile-time.