Skip to content

Commit

Permalink
refactor: canonicalize uses
Browse files Browse the repository at this point in the history
- use external paths over internal paths to signify true origin
- use `prelude` wherever possible
- use shortest possible paths
- expand grouped `use`s into multiple lines
- separate `use`s by blank line: `std`, external, `crate`, `super`
- don't explicitly `use` items covered by wildcard
  • Loading branch information
jan-ferdinand committed Jan 27, 2024
1 parent 56f038b commit 03b20ab
Show file tree
Hide file tree
Showing 139 changed files with 325 additions and 441 deletions.
2 changes: 1 addition & 1 deletion src/ast_types/tuple.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::triton_vm::triton_asm;
use itertools::Itertools;
use tasm_lib::triton_vm::triton_asm;

use crate::ast::FnSignature;
use crate::libraries::LibraryFunction;
Expand Down
14 changes: 7 additions & 7 deletions src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
use itertools::Itertools;
use std::collections::HashMap;
use std::env;
use std::fs;
use std::fs::File;
use std::io::Read;
use std::process;

use itertools::Itertools;
use syn::ImplItemMethod;
use syn::Item;
use syn::ItemEnum;
use syn::ItemImpl;
use syn::ItemStruct;
use syn::UseTree;
pub use tasm_lib;
use tasm_lib::prelude::*;
use tasm_lib::triton_vm::prelude::*;

// TODO: The following import is necessary until `tasm-lib` branch `prelude` is incorporated there.
#[allow(clippy::single_component_path_imports)]
pub use tasm_lib::triton_vm;
use tasm_lib::triton_vm::prelude::LabelledInstruction;
pub use tasm_lib::twenty_first;
// todo: this is temporarily required for derive macro `TasmObject` until its code generation is cleaned up
#[allow(unused_imports)]
use twenty_first;
use tasm_lib::twenty_first::prelude::BFieldElement;

use ast_types::ListType;
use graft::CustomTypeRust;
Expand Down
5 changes: 2 additions & 3 deletions src/libraries/bfe.rs
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
use crate::triton_vm::prelude::*;
use crate::triton_vm::triton_asm;
use crate::triton_vm::twenty_first::shared_math::traits::PrimitiveRootOfUnity;
use itertools::Itertools;
use num::One;
use num::Zero;
use tasm_lib::triton_vm::prelude::*;

use crate::ast;
use crate::ast_types;
use crate::graft::Graft;
use crate::subroutine::SubRoutine;
use crate::twenty_first::shared_math::traits::PrimitiveRootOfUnity;

use super::tasm_lib_snippet_to_fn_signature;
use super::Library;
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/bfield_codec.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
use crate::triton_vm::triton_asm;
use crate::LabelledInstruction;
use tasm_lib::memory::dyn_malloc;
use tasm_lib::triton_vm::prelude::*;

use crate::ast;
use crate::ast_types;
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/boxed.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use crate::triton_vm::triton_asm;
use crate::LabelledInstruction;
use num::One;
use tasm_lib::memory::dyn_malloc::DynMalloc;
use tasm_lib::triton_vm::prelude::triton_asm;
use tasm_lib::triton_vm::prelude::LabelledInstruction;

use crate::ast;
use crate::ast_types;
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/core.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use crate::LabelledInstruction;
use syn::punctuated::Punctuated;
use syn::token::Comma;
use syn::ExprMethodCall;
use tasm_lib::triton_vm::prelude::LabelledInstruction;

use crate::ast::Expr;
use crate::ast::FnSignature;
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/core/option_type.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use crate::triton_vm::triton_asm;
use tasm_lib::triton_vm::triton_asm;

use crate::ast;
use crate::ast::FnSignature;
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/core/result_type.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use crate::triton_vm::triton_asm;
use tasm_lib::triton_vm::triton_asm;

use crate::ast;
use crate::ast::FnSignature;
Expand Down
6 changes: 2 additions & 4 deletions src/libraries/hasher.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
use crate::triton_vm::prelude::*;
use crate::triton_vm::twenty_first::shared_math::tip5::DIGEST_LENGTH;
use crate::LabelledInstruction;
use tasm_lib::Digest;
use tasm_lib::triton_vm::prelude::*;
use tasm_lib::twenty_first::prelude::tip5::DIGEST_LENGTH;

use crate::ast;
use crate::ast_types;
Expand Down
3 changes: 2 additions & 1 deletion src/libraries/tasm.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
use tasm_lib::triton_vm::prelude::*;

use crate::ast;
use crate::ast_types;
use crate::graft::Graft;
use crate::tasm_code_generator::CompilerState;
use crate::triton_vm::prelude::*;

use super::tasm_lib_snippet_to_fn_signature;
use super::Library;
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/unsigned_integers.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::triton_vm::prelude::*;
use tasm_lib::traits::basic_snippet::BasicSnippet;
use tasm_lib::triton_vm::prelude::*;

use crate::ast;
use crate::ast_types;
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/vector.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
use crate::triton_vm::triton_asm;
use crate::LabelledInstruction;
use itertools::Itertools;
use num::One;
use tasm_lib::memory::memcpy::MemCpy;
use tasm_lib::traits::basic_snippet::BasicSnippet;
use tasm_lib::triton_vm::prelude::LabelledInstruction;
use tasm_lib::triton_vm::triton_asm;

use crate::ast;
use crate::ast::FnSignature;
Expand Down
6 changes: 2 additions & 4 deletions src/libraries/xfe.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
use crate::triton_vm::prelude::*;
use crate::triton_vm::triton_asm;
use crate::triton_vm::twenty_first::shared_math::x_field_element::XFieldElement;
use crate::triton_vm::twenty_first::shared_math::x_field_element::EXTENSION_DEGREE;
use itertools::Itertools;
use num::One;
use num::Zero;
use tasm_lib::triton_vm::prelude::*;
use tasm_lib::twenty_first::prelude::x_field_element::EXTENSION_DEGREE;

use crate::ast;
use crate::ast_types;
Expand Down
2 changes: 1 addition & 1 deletion src/tasm_code_generator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use std::fmt::Display;
use tasm_lib::library::Library as SnippetState;
use tasm_lib::prelude::*;
use tasm_lib::triton_vm::prelude::*;
use tasm_lib::triton_vm::twenty_first::prelude::*;
use tasm_lib::twenty_first::prelude::*;

use self::function_state::FunctionState;
use self::function_state::VarAddr;
Expand Down
6 changes: 2 additions & 4 deletions src/tasm_code_generator/data_type.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
use crate::triton_vm::op_stack::OpStackElement;
use crate::triton_vm::prelude::*;
use crate::triton_vm::triton_asm;
use crate::LabelledInstruction;
use tasm_lib::memory::memcpy::MemCpy;
use tasm_lib::triton_vm::op_stack::OpStackElement;
use tasm_lib::triton_vm::prelude::*;

use crate::ast_types;
use crate::tasm_code_generator::read_n_words_from_memory;
Expand Down
19 changes: 11 additions & 8 deletions src/tasm_code_generator/data_type/array_type.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
use crate::ast::{self, ArrayExpression};
use crate::tasm_code_generator::{
compile_expr, pop_n, write_n_words_to_memory_leaving_address, CompilerState,
};
use crate::triton_vm::triton_asm;
use crate::type_checker::GetType;
use crate::LabelledInstruction;
use crate::{ast_types, type_checker};
use itertools::Itertools;
use tasm_lib::triton_vm::prelude::*;

use crate::ast;
use crate::ast::ArrayExpression;
use crate::ast_types;
use crate::tasm_code_generator::compile_expr;
use crate::tasm_code_generator::pop_n;
use crate::tasm_code_generator::write_n_words_to_memory_leaving_address;
use crate::tasm_code_generator::CompilerState;
use crate::type_checker;
use crate::type_checker::GetType;

pub(crate) fn compile_array_expr(
state: &mut CompilerState,
Expand Down
5 changes: 1 addition & 4 deletions src/tasm_code_generator/data_type/enum_type.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
use crate::triton_vm::prelude::*;
use crate::triton_vm::triton_asm;
use crate::triton_vm::triton_instr;
use crate::LabelledInstruction;
use tasm_lib::triton_vm::prelude::*;

use crate::ast;
use crate::ast_types;
Expand Down
5 changes: 1 addition & 4 deletions src/tasm_code_generator/data_type/struct_type.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use crate::triton_vm::prelude::*;
use crate::triton_vm::triton_asm;
use crate::triton_vm::triton_instr;
use crate::LabelledInstruction;
use num::Zero;
use tasm_lib::triton_vm::prelude::*;

use crate::ast_types;
use crate::ast_types::StructVariant;
Expand Down
8 changes: 5 additions & 3 deletions src/tasm_code_generator/data_type/tuple_type.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
use tasm_lib::triton_vm::prelude::LabelledInstruction;
use tasm_lib::triton_vm::triton_asm;

use crate::ast_types::Tuple;
use crate::tasm_code_generator::{move_top_stack_value_to_memory, CompilerState};
use crate::triton_vm::triton_asm;
use crate::LabelledInstruction;
use crate::tasm_code_generator::move_top_stack_value_to_memory;
use crate::tasm_code_generator::CompilerState;

impl Tuple {
/// ```text
Expand Down
3 changes: 2 additions & 1 deletion src/tasm_code_generator/inner_function_tasm_code.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use tasm_lib::triton_vm::triton_asm;

use crate::subroutine::SubRoutine;
use crate::triton_vm::triton_asm;

#[derive(Clone, Debug)]
pub(crate) struct InnerFunctionTasmCode {
Expand Down
18 changes: 10 additions & 8 deletions src/tasm_code_generator/match_code.rs
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
use crate::triton_vm::triton_asm;
use crate::LabelledInstruction;
use std::collections::HashSet;

use itertools::Itertools;
use num::One;
use std::collections::HashSet;
use tasm_lib::triton_vm::prelude::LabelledInstruction;
use tasm_lib::triton_vm::triton_asm;

use super::compile_block_stmt;
use super::compile_returning_block_expr;
use super::pop_n;
use super::CompilerState;
use super::ValueIdentifier;
use crate::ast;
use crate::ast::MatchCondition;
use crate::ast::MatchExpr;
Expand All @@ -18,6 +14,12 @@ use crate::type_checker;
use crate::type_checker::GetType;
use crate::type_checker::Typing;

use super::compile_block_stmt;
use super::compile_returning_block_expr;
use super::pop_n;
use super::CompilerState;
use super::ValueIdentifier;

impl MatchExpr<Typing> {
/// Return the code that evaluates to true iff the catch-all branch in a match statement
/// should be taken.
Expand Down
8 changes: 3 additions & 5 deletions src/tasm_code_generator/outer_function_tasm_code.rs
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
use std::collections::HashMap;
use std::str::FromStr;

use crate::triton_vm::instruction;
use crate::triton_vm::op_stack::NumberOfWords;
use crate::triton_vm::prelude::*;
use crate::triton_vm::triton_asm;
use crate::LabelledInstruction;
use chrono::Local;
use itertools::Itertools;
use tasm_lib::library::Library as SnippetState;
use tasm_lib::triton_vm::instruction;
use tasm_lib::triton_vm::op_stack::NumberOfWords;
use tasm_lib::triton_vm::prelude::*;

use crate::ast;
use crate::ast_types;
Expand Down
3 changes: 1 addition & 2 deletions src/tasm_code_generator/stack.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
use crate::triton_vm::prelude::*;
use crate::LabelledInstruction;
use itertools::Itertools;
use tasm_lib::triton_vm::prelude::*;

use crate::ast_types;

Expand Down
1 change: 1 addition & 0 deletions src/tests_and_benchmarks/benchmarks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ use std::fs::create_dir_all;
use std::io::Write;
use std::path::Path;
use std::path::PathBuf;

use tasm_lib::snippet_bencher::write_benchmarks;
use tasm_lib::snippet_bencher::BenchmarkCase;
use tasm_lib::snippet_bencher::BenchmarkResult;
Expand Down
11 changes: 5 additions & 6 deletions src/tests_and_benchmarks/benchmarks/mmr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@
mod benchmark {
use std::collections::HashMap;

use crate::triton_vm::prelude::*;
use crate::triton_vm::twenty_first::shared_math::other::random_elements;
use crate::triton_vm::twenty_first::shared_math::tip5::Tip5;
use crate::triton_vm::twenty_first::util_types::mmr::mmr_accumulator::MmrAccumulator;
use crate::triton_vm::twenty_first::util_types::mmr::mmr_trait::Mmr;

use rand::random;
use tasm_lib::rust_shadowing_helper_functions;
use tasm_lib::triton_vm::prelude::*;
use tasm_lib::twenty_first::shared_math::other::random_elements;
use tasm_lib::twenty_first::shared_math::tip5::Tip5;
use tasm_lib::twenty_first::util_types::mmr::mmr_accumulator::MmrAccumulator;
use tasm_lib::twenty_first::util_types::mmr::mmr_trait::Mmr;
use tasm_lib::Digest;

use crate::tests_and_benchmarks::benchmarks::execute_and_write_benchmark;
Expand Down
2 changes: 1 addition & 1 deletion src/tests_and_benchmarks/ozk/ozk_parsing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ use crate::ast_types;
use crate::custom_type_resolver::resolve_custom_types;
use crate::extract_types_and_function;
use crate::tasm_code_generator::compile_function;
use crate::triton_vm::prelude::*;
use crate::type_checker::annotate_fn_outer;
use crate::StructsAndMethodsRustAst;
use tasm_lib::triton_vm::prelude::*;

const MANIFEST_DIR: &str = env!("CARGO_MANIFEST_DIR");
const PROGRAMS_DIR: &str = "src/tests_and_benchmarks/ozk/programs";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use crate::triton_vm::prelude::*;
use tasm_lib::triton_vm::prelude::*;

use crate::tests_and_benchmarks::ozk::rust_shadows as tasm;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use crate::triton_vm::prelude::*;
use tasm_lib::triton_vm::prelude::*;

use crate::tests_and_benchmarks::ozk::rust_shadows as tasm;

Expand Down Expand Up @@ -56,8 +56,7 @@ fn main() {

#[cfg(test)]
mod test {
use crate::triton_vm::prelude::*;
use crate::triton_vm::twenty_first::shared_math::bfield_codec::BFieldCodec;
use tasm_lib::triton_vm::prelude::*;

use proptest::collection::vec;
use proptest::prelude::*;
Expand Down Expand Up @@ -92,7 +91,7 @@ mod test {
}

mod benches {
use crate::triton_vm::prelude::*;
use tasm_lib::triton_vm::prelude::*;

use crate::tests_and_benchmarks::benchmarks::execute_and_write_benchmark;
use crate::tests_and_benchmarks::benchmarks::profile;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::triton_vm::prelude::*;
use crate::triton_vm::twenty_first::shared_math::traits::ModPowU32;
use num::One;
use tasm_lib::triton_vm::prelude::*;
use tasm_lib::twenty_first::shared_math::traits::ModPowU32;

use crate::tests_and_benchmarks::ozk::rust_shadows as tasm;

Expand Down
3 changes: 1 addition & 2 deletions src/tests_and_benchmarks/ozk/programs/arithmetic/montyred.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ fn main() {
#[cfg(test)]
mod test {

use crate::triton_vm::prelude::*;
use crate::triton_vm::twenty_first::shared_math::bfield_codec::BFieldCodec;
use tasm_lib::triton_vm::prelude::*;

use itertools::Itertools;

Expand Down
4 changes: 2 additions & 2 deletions src/tests_and_benchmarks/ozk/programs/arrays/bfe_array.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::triton_vm::prelude::*;
use num::Zero;
use tasm_lib::triton_vm::prelude::*;

use crate::tests_and_benchmarks::ozk::rust_shadows as tasm;

Expand Down Expand Up @@ -53,7 +53,7 @@ fn main() {

#[cfg(test)]
mod test {
use crate::triton_vm::prelude::*;
use tasm_lib::triton_vm::prelude::*;

use itertools::Itertools;
use rand::random;
Expand Down
Loading

0 comments on commit 03b20ab

Please sign in to comment.