Remove the inbound message handling to get the Rails upgrade done. Pu…

…ll requests for re-implementing with ActionMailbox are welcome.

Fixes #2463.

app/controllers/integrations_controller.rb

@@ -1,8 +1,7 @@
 class IntegrationsController < ApplicationController
   require 'mail'
 
-  skip_before_action :login_required, :only => [:cloudmailin, :search_plugin]
-  skip_before_action :verify_authenticity_token, only: [:cloudmailin]
+  skip_before_action :login_required, :only => [:search_plugin]
 
   def index
     @page_title = 'TRACKS::Integrations'
@@ -21,31 +20,8 @@ def search_plugin
       .pack('m').gsub(/\n/, '')
   end
 
-  def cloudmailin
-    if !verify_cloudmailin_signature
-      render :body => "Message signature verification failed.", :status => 403
-      return false
-    end
-
-    if process_message(params[:message])
-      render :body => 'success', :status => 200
-    else
-      render :body => "No user found or other error", :status => 404
-    end
-  end
-
   private
 
-  def process_message(message)
-    MessageGateway.receive(Mail.new(message))
-  end
-
-  def verify_cloudmailin_signature
-    provided = request.request_parameters.delete(:signature)
-    signature = Digest::MD5.hexdigest(flatten_params(request.request_parameters).sort.map { |k, v| v }.join + SITE_CONFIG['cloudmailin'])
-    return provided == signature
-  end
-
   def flatten_params(params, title = nil, result = {})
     params.each do |key, value|
       if value.is_a? Hash

app/views/integrations/index.html.erb

@@ -4,8 +4,6 @@
 <br/><p><%= I18n.t 'integrations.contents_header' %></p>
 <ul>
   <li><a href="#email-cron-section"><%= I18n.t 'integrations.sections.automatic_email' %></a></li>
-  <li><a href="#message_gateway"><%= I18n.t 'integrations.sections.message_gateway' %></a></li>
-  <li><a href="#mailgun"><%= I18n.t 'integrations.sections.mailgun' %></a></li>
   <li><a href="#todo_rich_message_format"><%= I18n.t 'integrations.sections.email_rich' %></a></li>
 </ul>
 <p><%= raw I18n.t 'integrations.add_your_own', tell_us_link: link_to(I18n.t('integrations.tell_us_link_text'), 'https://github.com/TracksApp/tracks/issues') %></p>
@@ -19,41 +17,6 @@
 
 <p><%= raw I18n.t 'integrations.cron_2', feeds_link: link_to(I18n.t('integrations.feeds_link_text'), feeds_path) %></p>
 
-<a name="message_gateway"> </a>
-<h2><%= I18n.t 'integrations.sections.message_gateway' %></h2>
-<p><%= I18n.t 'integrations.message_gateway.description' %></p>
-<ul>
-  <li><%= raw I18n.t 'integrations.message_gateway.instructions.1', preferences_link: link_to(t('layouts.navigation.preferences'), preferences_url), sms_email_name: Preference.human_attribute_name('sms_email'), sms_context_name: Preference.human_attribute_name('sms_context') %></li>
-  <li><%= raw I18n.t 'integrations.message_gateway.instructions.2', command: "<pre>/PATH/TO/TRACKS/bin/rails r -e production 'MessageGateway.receive(STDIN.read)'</pre>" %></li>
-  <li><%= I18n.t 'integrations.message_gateway.instructions.3' %></li>
-</ul>
-<p><%= I18n.t 'integrations.message_gateway.rich_api_tip' %></p>
-<p><%= raw I18n.t 'integrations.message_gateway.configuration', site_yml: '<tt>site.yml</tt>', to_name: '<tt>to:</tt>', from_name: '<tt>from:</tt>' %></p>
-<p><%= raw I18n.t 'integrations.message_gateway.one_user_configuration', single_user_value: '<tt>single_user</tt>', code: "<pre>TRACKS_MAIL_RECEIVER=" + current_user.login + " /PATH/TO/TRACKS/bin/rails r -e production 'MessageGateway.receive(STDIN.read)'</pre>" %></p>
-
-<a name="mailgun"> </a>
-<h2><%= I18n.t 'integrations.sections.mailgun' %></h2>
-<p><%= raw I18n.t 'integrations.mailgun.description', mailgun_link: link_to('Mailgun', 'http://www.mailgun.com/') %></p>
-<p><%= I18n.t 'integrations.mailgun.conditions' %></p>
-<ul>
-  <li><%= raw I18n.t 'integrations.mailgun.instructions.1', mailgun_link: link_to('Mailgun', 'http://www.mailgun.com/') %></li>
-  <li><%= I18n.t 'integrations.mailgun.instructions.2' %></li>
-  <ul>
-    <li><%= I18n.t 'integrations.mailgun.instructions.2a' %></li>
-    <li><%= I18n.t 'integrations.mailgun.instructions.2b' %></li>
-  </ul>
-  <li><%= raw I18n.t 'integrations.mailgun.instructions.3', preferences_link: link_to(t('layouts.navigation.preferences'), preferences_url), sms_email_name: Preference.human_attribute_name('sms_email') %></li>
-  <li><%= I18n.t 'integrations.mailgun.instructions.4', sms_context_name: Preference.human_attribute_name('sms_context') %></li>
-  <li><%= I18n.t 'integrations.mailgun.instructions.5' %></li>
-  <li><%= raw I18n.t 'integrations.mailgun.instructions.6', code: '<pre class=code>
-mailmap:
-  [email protected]:
-  - [email protected]
-  - [email protected]
-</pre>' %></li>
-</ul>
-<p><%= I18n.t 'integrations.mailgun.gateway_instructions' %></p>
-
 <a name="todo_rich_message_format"> </a>
 <h2><%= I18n.t 'integrations.sections.email_rich' %></h2>
 <p><%= I18n.t 'integrations.email_rich.description' %></p>