Add static typing with Python type annotations #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNiendorf
force-pushed
the
static_types
branch
from
674533c to
edc1012
Compare
GNiendorf
force-pushed
the
static_types
branch
from
0ef89ce to
03c34ee
Compare
GNiendorf
force-pushed
the
static_types
branch
from
03c34ee to
048ef96
Compare
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds static typing for almost all functions in tracepy. A few functions, like glass_index, need fixing before static typing is added. I also moved many of the constants used in the code to a new constants.py file, and added a new exception "InvalidGeometry" for invalid geometry inputs given by a user. The gen_rot function was moved to utils.py to remove a circular import. Lastly, I broke up the transform.py functions to allow for static typing, since having two different return types was causing an issue.